Attachments package #159
Open
Attachments package #159
+3,177
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
commented
Apr 8, 2025
There was a problem hiding this comment.
Copilot reviewed 45 out of 47 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- connectors/supabase/build.gradle.kts: Language not supported
- core/build.gradle.kts: Language not supported
Comments suppressed due to low confidence (1)
core/README.md:27
- Consider correcting 'it database API' to 'its database API' for proper grammatical accuracy.
of [SQLDelight](https://sqldelight.github.io/sqldelight/latest/) for it database API and typesafe database
core/src/commonMain/kotlin/com/powersync/attachments/sync/SyncingService.kt
Show resolved
Hide resolved
simolus3
reviewed
Apr 22, 2025
core/src/commonMain/kotlin/com/powersync/attachments/storage/IOLocalStorageAdapter.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/com/powersync/attachments/implementation/AttachmentServiceImpl.kt
Show resolved
Hide resolved
core/src/commonMain/kotlin/com/powersync/attachments/implementation/AttachmentContextImpl.kt
Show resolved
Hide resolved
core/src/commonMain/kotlin/com/powersync/attachments/sync/SyncingService.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/com/powersync/attachments/sync/SyncingService.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds attachments helper functionality to the PowerSync Core module.
For full context. See the README
This implementation is a combination of the approach taken in the JS and Dart implementations.
AttachmentsServicewhich handles Attachment state persisting and a Syncing service which processes the queue.AttachmentQueuehere is not abstract, it provides a common and simple default implementation for certain operations. The class isopenand can be extended if developers require custom functionality.Demo
See the small video demonstrating syncing attachments between two devices
attachment_demo.mp4
TODOS